Repository navigation
refactor!: Remove the kraft cloud subcommands - #2937
Draft
craciunoiuc wants to merge 6 commits into
Draft
craciunoiuc wants to merge 6 commits into
craciunoiuc wants to merge 6 commits into
Conversation
The `kraft cloud` subcommands move to the `unikraft` CLI. The cloud e2e suite, its Makefile target and its CI job test code that goes. Remove `test/e2e/cloud`, the `test-cloud-e2e` target and the `e2e-cloud-cli` job. The `e2e-cli` job still runs framework tests. Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
The `kraft pkg` commands carry hidden Unikraft Cloud flags. They resolve a metro and a token and turn them into registry auth. Remove the `--metro`, `--token` and `--allow-insecure` flags and their setup. Use `kraft login` to set registry auth. Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
Local commands such as `kraft ps` and `kraft pkg ls` import the output format check from the cloud command utilities. Add `IsValidOutputFormat` to `internal/cli/kraft/utils` and point local commands at it. Add a unit test for the supported formats. Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
The `kraft cloud` subcommands move to the `unikraft` CLI. Keeping them in kraftkit carries the cloud SDKs and a large unused tree. Remove the cloud commands, their SDKs and the deprecation config. A hidden `kraft cloud` stub points to the `unikraft` CLI docs. Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
Each run reads Unikraft Cloud tokens from `UKC_TOKEN` and similar variables and turns them into registry auth for the cloud index. Remove this auth logic from kraft and the GitHub action. Use `kraft login` or the config `auths` to set registry auth. Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
The README lists deployment to Unikraft Cloud as a KraftKit feature. KraftKit no longer has cloud commands. Remove the cloud deployment item from the feature list. Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
Description of changes
Remove the Unikraft Cloud offering from kraftkit.
kraft cloudis now ahidden stub that points to the
unikraftCLIand exits with an error. The cloud commands, SDKs, auth,
kraft pkgmetro/token flags and the cloud e2e suite and CI job are removed.